FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 43 |
43 |
0 |
0 |
com.simpligility.maven.plugins.androidndk.AndroidNdk
| Bug |
Category |
Details |
Line |
Priority |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.ARM_64_TOOLCHAIN is a mutable array |
MALICIOUS_CODE |
MS_MUTABLE_ARRAY |
50 |
High |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.ARM_TOOLCHAIN is a mutable array |
MALICIOUS_CODE |
MS_MUTABLE_ARRAY |
44 |
High |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.NDK_ARCHITECTURES is a mutable array |
MALICIOUS_CODE |
MS_MUTABLE_ARRAY |
39 |
High |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.X86_64_TOOLCHAIN is a mutable array |
MALICIOUS_CODE |
MS_MUTABLE_ARRAY |
60 |
High |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.X86_TOOLCHAIN is a mutable array |
MALICIOUS_CODE |
MS_MUTABLE_ARRAY |
55 |
High |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.MIPS_TOOLCHAIN should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
65 |
Medium |
| com.simpligility.maven.plugins.androidndk.AndroidNdk.MIPS_64_TOOLCHAIN should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
68 |
Low |
com.simpligility.maven.plugins.androidndk.CommandExecutor$Factory$DefaultCommandExecutor
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of CommandExecutor$Factory$DefaultCommandExecutor.logger at line 236 of value previously dereferenced in com.simpligility.maven.plugins.androidndk.CommandExecutor$Factory$DefaultCommandExecutor.executeCommand(String, List, File, boolean) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
234 |
High |
com.simpligility.maven.plugins.androidndk.PluginInfo
| Bug |
Category |
Details |
Line |
Priority |
| com.simpligility.maven.plugins.androidndk.PluginInfo.loadProperties() may fail to clean up java.io.InputStream on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
32 |
Medium |
| com.simpligility.maven.plugins.androidndk.PluginInfo.loadProperties() may fail to close stream on exception |
BAD_PRACTICE |
OS_OPEN_STREAM_EXCEPTION_PATH |
32 |
Low |
com.simpligility.maven.plugins.androidndk.common.ArtifactResolverHelper
| Bug |
Category |
Details |
Line |
Priority |
| com.simpligility.maven.plugins.androidndk.common.ArtifactResolverHelper.EXCLUDE_NON_PACKAGED_SCOPES is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
37 |
Medium |
com.simpligility.maven.plugins.androidndk.common.NativeHelper
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to acceptedFiles in com.simpligility.maven.plugins.androidndk.common.NativeHelper.listNativeFiles(Artifact, File, boolean, String) |
STYLE |
DLS_DEAD_LOCAL_STORE |
444 |
High |
| Found reliance on default encoding in com.simpligility.maven.plugins.androidndk.common.NativeHelper.getAppAbi(File): new java.util.Scanner(File) |
I18N |
DM_DEFAULT_ENCODING |
285 |
High |
| Should com.simpligility.maven.plugins.androidndk.common.NativeHelper.getAppAbi(File) return a zero length array rather than null? |
STYLE |
PZLA_PREFER_ZERO_LENGTH_ARRAYS |
307 |
Low |
| Exception is caught when Exception is not thrown in com.simpligility.maven.plugins.androidndk.common.NativeHelper.processTransitiveDependencies(Dependency, boolean) |
STYLE |
REC_CATCH_EXCEPTION |
216 |
Low |
| Exception is caught when Exception is not thrown in com.simpligility.maven.plugins.androidndk.common.NativeHelper.validateNDKVersion(File) |
STYLE |
REC_CATCH_EXCEPTION |
246 |
Low |
com.simpligility.maven.plugins.androidndk.common.NativeHelper$1
| Bug |
Category |
Details |
Line |
Priority |
| The class com.simpligility.maven.plugins.androidndk.common.NativeHelper$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
184-188 |
Low |
com.simpligility.maven.plugins.androidndk.common.UnpackedLibHelper
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in com.simpligility.maven.plugins.androidndk.common.UnpackedLibHelper.extractAarLib(Artifact) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
138 |
Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in com.simpligility.maven.plugins.androidndk.common.UnpackedLibHelper.extractAarLib(Artifact) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
118 |
Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in com.simpligility.maven.plugins.androidndk.common.UnpackedLibHelper.extractApklib(Artifact) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
84 |
Medium |
com.simpligility.maven.plugins.androidndk.configuration.HeaderFilesDirective
| Bug |
Category |
Details |
Line |
Priority |
| com.simpligility.maven.plugins.androidndk.configuration.HeaderFilesDirective.getExcludes() may expose internal representation by returning HeaderFilesDirective.excludes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
46 |
Medium |
| com.simpligility.maven.plugins.androidndk.configuration.HeaderFilesDirective.getIncludes() may expose internal representation by returning HeaderFilesDirective.includes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
56 |
Medium |
| com.simpligility.maven.plugins.androidndk.configuration.HeaderFilesDirective.setExcludes(String[]) may expose internal representation by storing an externally mutable object into HeaderFilesDirective.excludes |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
51 |
Medium |
| com.simpligility.maven.plugins.androidndk.configuration.HeaderFilesDirective.setIncludes(String[]) may expose internal representation by storing an externally mutable object into HeaderFilesDirective.includes |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
61 |
Medium |
com.simpligility.maven.plugins.androidndk.phase00clean.HelpMojo
| Bug |
Category |
Details |
Line |
Priority |
| Usage of GetResource in com.simpligility.maven.plugins.androidndk.phase00clean.HelpMojo.build() may be unsafe if class is extended |
BAD_PRACTICE |
UI_INHERITANCE_UNSAFE_GETRESOURCE |
73 |
Low |
com.simpligility.maven.plugins.androidndk.phase00clean.NdkCleanMojo
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: com.simpligility.maven.plugins.androidndk.phase00clean.NdkCleanMojo.skipBuildLibsOutputDirectory |
PERFORMANCE |
URF_UNREAD_FIELD |
42 |
Medium |
| Unread field: com.simpligility.maven.plugins.androidndk.phase00clean.NdkCleanMojo.skipBuildObjsOutputDirectory |
PERFORMANCE |
URF_UNREAD_FIELD |
49 |
Medium |
| Unread field: com.simpligility.maven.plugins.androidndk.phase00clean.NdkCleanMojo.skipClean |
PERFORMANCE |
URF_UNREAD_FIELD |
34 |
Medium |
| Unused field: com.simpligility.maven.plugins.androidndk.phase00clean.NdkCleanMojo.ndkBuildLibsOutputDirectory |
PERFORMANCE |
UUF_UNUSED_FIELD |
Not available |
Medium |
| Unused field: com.simpligility.maven.plugins.androidndk.phase00clean.NdkCleanMojo.ndkBuildObjOutputDirectory |
PERFORMANCE |
UUF_UNUSED_FIELD |
Not available |
Medium |
com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to classifier in com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper.addLocalModule(MakefileHelper$LibraryDetails) |
STYLE |
DLS_DEAD_LOCAL_STORE |
354 |
Low |
com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper$1
| Bug |
Category |
Details |
Line |
Priority |
| The class com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
371-375 |
Low |
com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper$LibraryDetails
| Bug |
Category |
Details |
Line |
Priority |
| Should com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper$LibraryDetails be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
49 |
Medium |
| Unread field: com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper$LibraryDetails.localModuleFileName |
PERFORMANCE |
URF_UNREAD_FIELD |
467 |
Medium |
| Unused field: com.simpligility.maven.plugins.androidndk.phase05compile.MakefileHelper$LibraryDetails.localSrcFiles |
PERFORMANCE |
UUF_UNUSED_FIELD |
Not available |
Medium |
com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to libsOut in com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.setupOutputDirectories(NdkBuildMojo$CompileCommand) |
STYLE |
DLS_DEAD_LOCAL_STORE |
419 |
Medium |
| Dead store to out in com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.setupOutputDirectories(NdkBuildMojo$CompileCommand) |
STYLE |
DLS_DEAD_LOCAL_STORE |
420 |
Medium |
| com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.attachHeaderFiles(NdkBuildMojo$CompileCommand, File, List) may fail to clean up java.io.InputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
981 |
Medium |
| com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.attachHeaderFiles(NdkBuildMojo$CompileCommand, File, List) may fail to close stream |
BAD_PRACTICE |
OS_OPEN_STREAM |
981 |
Medium |
| Exception is caught when Exception is not thrown in com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.compile(NdkBuildMojo$CompileCommand) |
STYLE |
REC_CATCH_EXCEPTION |
573 |
Medium |
| Exception is caught when Exception is not thrown in com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.createHeaderArchive(NdkBuildMojo$CompileCommand, List, List) |
STYLE |
REC_CATCH_EXCEPTION |
1046 |
Low |
| Exceptional return value of java.io.File.mkdirs() ignored in com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo.compile(NdkBuildMojo$CompileCommand) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
472 |
Medium |
com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo$CompileCommand
| Bug |
Category |
Details |
Line |
Priority |
| Should com.simpligility.maven.plugins.androidndk.phase05compile.NdkBuildMojo$CompileCommand be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
433-448 |
Medium |
